This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix bugs encountered with Auth flow #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
previously approved these changes
Dec 4, 2019
schottra
force-pushed
the
fix-auth-redirect
branch
from
c0cf0f7 to
6fd6735
Compare
| // Enable CORS if necessary on the gateway mux by adding a handler for all OPTIONS requests. | ||
| if cfg.Security.AllowCors { | ||
| globPattern := server.GetGlobPattern() | ||
| decorator := auth.GetCorsDecorator(ctx, cfg.Security.AllowedOrigins, cfg.Security.AllowedHeaders) |
There was a problem hiding this comment.
how does it handle OPTIONS calls if this bit is removed?
There was a problem hiding this comment.
The Cors middleware wraps the mux and processes all requests, passing them through to the mux unless there's an error of some sort (disallowed origin, etc). It will handle all OPTIONS requests and add the appropriate headers based on the configuration.
…straint for gorilla
katrogan
approved these changes
Dec 4, 2019
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Simplifying our CORS implementation to use a global middleware * Making content-type header a default, using a less strict version constraint for gorilla
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting CORS headers for the
/meendpoint. In attempting to implement that, I found myself duplicating some code and went in search for a better way to handle CORS.I removed the custom CORS logic and replaced it with a simpler middleware-based implementation from
gorilla. It still pulls in the allowed headers and origins lists, but implements the origin matching in a way that is compatible with credentials and specifying multiple domains.This will also apply CORS to all future endpoints we add, since it's done at the level above the mux.