PL-131857 rbd pool migration #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses Ceph's RBD live migration and thus is quite fast and we continuously maintain the flattening during subsequent ensure() calls. Existing snapshots are kept. This includes a large refactoring to make the Ceph abstraction code easier to understand with the different requirements we now juggle. We basically have a relatively abstract "Ceph" object that is the entrance point to the cluster and some convenience APIs. Volumes are specific RBD volumes and their API and "VolumeSpecs" capture the logic we have around Root/Tmp/Swap volumes and their details. They get embedded into a streamlined process of starting/ensuring/stopping so the agent and ceph manager objects can handle them pretty "blindly". They are reachable as well known names, though, to make it easier to handle the few special cases in the higher layers. re PL-131857
(test separation part 2, record intermittent changes)
ctheune
force-pushed
the
PL-131857-rbd-pool-migration
branch
from
482bd55 to
1fcf21c
Compare
ctheune
force-pushed
the
PL-131857-rbd-pool-migration
branch
from
1fcf21c to
960184c
Compare
|
@sysvinit and I reviewed this together last week and I only did a few fixups afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support automatically migrating VM root disks between different RBD tools using Ceph's "RBD live migration" feature.
Also includes a number of refactorings and paying down some technical debt.
PL-131857