Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call command on backup completion #53

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Call command on backup completion #53

merged 1 commit into from
Oct 5, 2023

Conversation

dhnasa
Copy link
Collaborator

@dhnasa dhnasa commented Sep 7, 2023 •
edited
Loading

Related issue(s): DIR-770, #47

  • Change is documented in changelog

Security implications

  • Backy will call any configured command/script without any security measures
    • should be fine as long as the config file is only writable by the backy user

@dhnasa dhnasa force-pushed the DIR-770-status-in-directory branch 5 times, most recently from 2fb0696 to 3fcd49d Compare September 13, 2023 15:26
@dhnasa dhnasa marked this pull request as ready for review September 13, 2023 15:29
@dhnasa dhnasa force-pushed the DIR-770-status-in-directory branch from 3fcd49d to b9efb06 Compare September 14, 2023 10:56
ctheune
ctheune requested changes Sep 14, 2023
View reviewed changes
src/backy/main.py Outdated Show resolved Hide resolved
src/backy/scheduler.py Show resolved Hide resolved
src/backy/tests/test_callback.sh Outdated Show resolved Hide resolved
src/backy/tests/test_daemon.py Outdated Show resolved Hide resolved
src/backy/tests/test_daemon.py Outdated Show resolved Hide resolved
@dhnasa dhnasa force-pushed the DIR-770-status-in-directory branch from b9efb06 to cf0ec41 Compare September 14, 2023 14:27
@dhnasa dhnasa requested a review from ctheune September 14, 2023 14:28
@dhnasa dhnasa force-pushed the DIR-770-status-in-directory branch from cf0ec41 to be2de57 Compare October 5, 2023 11:48
@dhnasa dhnasa force-pushed the DIR-770-status-in-directory branch from be2de57 to 1f5aa94 Compare October 5, 2023 11:50
@ctheune ctheune merged commit b12b732 into main Oct 5, 2023
3 checks passed
@dhnasa dhnasa deleted the DIR-770-status-in-directory branch October 5, 2023 12:02
@dhnasa dhnasa mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctheune ctheune ctheune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhnasa @ctheune