feat(refactor): move server and client logic to their own package #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfantone
changed the title
nfantone
reviewed
May 27, 2019
| @@ -0,0 +1,40 @@ | |||
| 'use strict'; | |||
|
|
|||
| const PRESETS = { | |||
There was a problem hiding this comment.
Not the best implementation but should work for now
added 12 commits
May 28, 2019 09:01
crash7
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Decide to move the whole package into to different modules. The main motivation was to reduce the bundle in the application and do not include server only stuff in the web, like, for example
@loadable/server. Also while I was doing this, I discovered that the final bundle wasn't ok and was including unnecessary polyfills and ReactDOM/server.Moved before.js to a monorepo with two packages:
@before/clientand@before/server.The server package include all the server related stuff that should only run while server side rendering, like the
rendermethod.On the other side, the client expose the
Beforecomponent and the ensure ready methods.Another side-effect of this implementation is that each bundle as it's own build target.
todo list