This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add support for empty/none services in update #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenhansendk
force-pushed
the
fix-empty-services-on-update
branch
from
619d2af
to
057d55e
Compare
sorenhansendk
force-pushed
the
fix-empty-services-on-update
branch
from
057d55e
to
dd9de33
Compare
sorenhansendk
changed the title
sorenhansendk
changed the title
|
Hi @DAlperin 🙋♂️ I wanted to reach out regarding some open pull requests I've submitted to this project. While I'm enthusiastic about contributing and have put effort into these contributions, they have remained unanswered for some time. Is there any plans for how this project should be developed in the future? I can see you created a pretty exiting PR some days ago (#247) 👍 |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, once services are activated on a machine, they cannot be removed.
This pull request addresses this issue, and it also includes the addition of a new test.
Closes: #169
Closes: #151