switch node names to machine ID #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is fairly hidden, but wanted to make sure you had eyes on it: |
davissp14
reviewed
Aug 2, 2024
benwaffle
changed the title
davissp14
reviewed
Aug 7, 2024
benwaffle
added a commit
to superfly/flyctl
that referenced
this pull request
Aug 13, 2024
benwaffle
added a commit
to superfly/flyctl
that referenced
this pull request
Aug 13, 2024
benwaffle
added a commit
that referenced
this pull request
Aug 15, 2024
This reverts commit a39f76f.
benwaffle
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6pn as node name causes us some problems
https://github.com/superfly/postgres-stub/issues/5
TODO:
fly image updateworks from 6pn node names to machine ID node names[%s]:5500which assume the node name is a 6pn