Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deregister standbys after x mins of inactivity #23

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Deregister standbys after x mins of inactivity #23

merged 1 commit into from
Dec 22, 2022

Conversation

DAlperin
Copy link
Member

Will fix to use replication slots later this is just a quick mvp

@DAlperin
Copy link
Member Author

Tested by:

  1. Setting up two node cluster: one primary, one standby
  2. Set timeout to 1 minute instead of default 10
  3. Kill standby
  4. Verify standby no longer present in cluster after 1 minute
  5. Restart standby and verify it cleanly rejoins cluster

I've decided to start writing down some test steps for myself to hopefully make writing integration tests easier eventually

davissp14
davissp14 requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note, but overall looks good!

cmd/standby_cleaner/main.go Outdated Show resolved Hide resolved
@DAlperin DAlperin merged commit c05e48c into master Dec 22, 2022
@davissp14 davissp14 deleted the remove_standbys branch February 25, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davissp14 davissp14 davissp14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DAlperin @davissp14