Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HAProxy version to latest LTS #205

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Jun 20, 2023

…image

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Contributor Author

Can anyone review this?

@davissp14
Copy link
Contributor

@smorimoto I'll do my best to take a look at this tomorrow!

@smorimoto
Copy link
Contributor Author

@davissp14 Thank you so much!

@davissp14
Copy link
Contributor

Looks like the build is failing with:

 => ERROR [stage-2  6/11] RUN apt-get update && apt-get install --no-install-recommends -y     haproxy=2.7.*     && apt autoremove -y                                                                                                                                                                                                                                6.8s
------
 > [stage-2  6/11] RUN apt-get update && apt-get install --no-install-recommends -y     haproxy=2.7.*     && apt autoremove -y:
#11 0.763 Hit:1 http://deb.debian.org/debian bookworm InRelease
#11 0.763 Hit:2 http://deb.debian.org/debian bookworm-updates InRelease
#11 0.791 Hit:3 http://deb.debian.org/debian-security bookworm-security InRelease
#11 0.869 Ign:4 http://haproxy.debian.net bookworm-backports-2.7 InRelease
#11 0.908 Hit:5 http://apt.postgresql.org/pub/repos/apt bookworm-pgdg InRelease
#11 0.953 Err:6 http://haproxy.debian.net bookworm-backports-2.7 Release
#11 0.953   404  Not Found [IP: 5.161.44.145 80]
#11 3.863 Reading package lists...
#11 6.819 E: The repository 'http://haproxy.debian.net bookworm-backports-2.7 Release' does not have a Release file.
------
executor failed running [/bin/sh -c apt-get update && apt-get install --no-install-recommends -y     haproxy=$HAPROXY_VERSION.\*     && apt autoremove -y]: exit code: 100

Are you seeing the same thing when you run the following?

docker build .  --platform linux/amd64

@smorimoto
Copy link
Contributor Author

smorimoto commented Jul 17, 2023

HAProxy 2.7 does not exist in the bookworm, so we have to merge #204 first.
Ref: https://haproxy.debian.net/#distribution=Debian&release=bookworm&version=2.7

@davissp14
Copy link
Contributor

davissp14 commented Jul 19, 2023

Can we consolidate these two PR's since they dependent on each other?

@smorimoto
Copy link
Contributor Author

(Sorry. I woke up and was sleepy, so I wrote a comment in Japanese 😅)

Makes sense! I will merge another one into this PR.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Contributor Author

Done 🙂

@smorimoto smorimoto changed the title Update HAProxy repository to keep up with Debian version of postgres image Update HAProxy version to latest LTS Jul 21, 2023
@davissp14
Copy link
Contributor

Looks good! Thank you and sorry for the delay!

@davissp14 davissp14 merged commit f1c37a3 into fly-apps:master Jul 24, 2023
4 checks passed
@smorimoto
Copy link
Contributor Author

Likewise! There's no need to say sorry! 🤝

@smorimoto smorimoto deleted the bookworm branch July 24, 2023 17:07
@smorimoto
Copy link
Contributor Author

When will the new version be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants