Add a funtion to forge Android logd entry #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxo
requested changes
Mar 5, 2024
src/lib.rs
Outdated
| //! To forge android logd entry: | ||
| //! | ||
| //! ``` | ||
| //! android_logd_logger::low(buffer_id, pid, thread_id, secs, subsec_nanos, tag, priority, message).unwrap(); |
There was a problem hiding this comment.
Here's a typo. Should be log. Can you please also ensure that rustdoc catches the examples and tries to build them?
There was a problem hiding this comment.
Thank you for suggestion. I checked with the rustdoc
src/lib.rs
Outdated
| crate::logd::log(&record); | ||
|
|
||
| #[cfg(not(target_os = "android"))] | ||
| println!("buffer: {:?}, tag: {:?}, message: {:?}", buffer_id, tag, message); |
There was a problem hiding this comment.
Please forward the records in the not android case as well. This keeps the equals format.
There was a problem hiding this comment.
Of course, I was just not sure, I removed this conditional compilation
Remove the additional heavy dependency `chrono` by using `std::time::SystemTime` instead of secs and subsecs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function that constructs a custom log entry.
I can be used it forge log entries, for example, to forward logs for 3rd party app to lodg