Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from CodeFactor #29

Closed
wants to merge 1 commit into from
Closed

Conversation

azlam-abdulsalam
Copy link

This pull request applies style fixes from code review by CodeFactor.


For more information, click here.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 37.33681% with 240 lines in your changes are missing coverage. Please review.

Project coverage is 46.24%. Comparing base (88e114b) to head (23f4ec5).

Files Patch % Lines
...ackages/sfp-cli/src/core/metadata/MetadataFiles.ts 0.00% 52 Missing ⚠️
...-cli/src/core/package/diff/PackageComponentDiff.ts 0.00% 24 Missing ⚠️
packages/sfp-cli/src/core/utils/Fileutils.ts 0.00% 24 Missing ⚠️
...ages/sfp-cli/src/core/artifacts/ArtifactFetcher.ts 30.00% 21 Missing ⚠️
packages/sfp-cli/src/core/git/GitDiffUtil.ts 0.00% 18 Missing ⚠️
packages/sfp-cli/src/core/org/SFPOrg.ts 23.52% 13 Missing ⚠️
...e/package/packageCreators/CreateDiffPackageImpl.ts 0.00% 11 Missing ⚠️
packages/sfp-cli/src/core/git/Git.ts 0.00% 9 Missing ⚠️
...ages/sfp-cli/src/core/package/SfpPackageBuilder.ts 0.00% 8 Missing ⚠️
packages/sfp-cli/src/core/git/GitTags.ts 50.00% 6 Missing ⚠️
... and 23 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files          73       73           
  Lines        2820     2820           
  Branches      322      322           
=======================================
  Hits         1304     1304           
  Misses       1491     1491           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants