fix(deploy): print coverage warnings when source package fails

flxbl-io · Mar 18, 2024 · 3c3cacf · 3c3cacf
1 parent 7a8ee1a
commit 3c3cacf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/packages/sfp-cli/src/core/deployers/DeploySourceToOrgImpl.ts b/packages/sfp-cli/src/core/deployers/DeploySourceToOrgImpl.ts
@@ -43,7 +43,7 @@ export default class DeploySourceToOrgImpl implements DeploymentExecutor {
 
         this.writeResultToReport(result);
 
-        if (this.deploymentOptions.sourceTracking) {
+             if (this.deploymentOptions.sourceTracking) {
             await this.handleSourceTracking(this.org, this.logger, this.projectDir, result);
         }
 
@@ -67,7 +67,10 @@ export default class DeploySourceToOrgImpl implements DeploymentExecutor {
 
     private handlErrorMesasge(result: DeployResult): string {
         if (result.response.numberComponentErrors == 0) {
-            return 'Unable to fetch report, Check your org for details';
+            //Check for test coverage warnings
+            if (result.response.details.runTestResult.codeCoverageWarnings) {
+                return 'Unable to deploy due to unsatisfactory code coverage and/or test failures';
+            } else return 'Unable to fetch report, Check your org for details';
         } else if (result.response.numberComponentErrors > 0) {
             return this.constructComponentErrorMessage(result.response.details.componentFailures, this.logger);
         } else if (result.response.details.runTestResult) {
@@ -181,7 +184,10 @@ export default class DeploySourceToOrgImpl implements DeploymentExecutor {
 
         // Wait for polling to finish and get the DeployResult object
         const hoursInWaitTime = Number(this.deploymentOptions.waitTime) / 60;
-        const result = await deploy.pollStatus({ frequency: Duration.seconds(30), timeout: Duration.hours(hoursInWaitTime) });
+        const result = await deploy.pollStatus({
+            frequency: Duration.seconds(30),
+            timeout: Duration.hours(hoursInWaitTime),
+        });
         return result;
     }
 

diff --git a/packages/sfp-cli/src/core/display/DeployErrorDisplayer.ts b/packages/sfp-cli/src/core/display/DeployErrorDisplayer.ts
@@ -38,7 +38,10 @@ export default class DeployErrorDisplayer {
         SFPLogger.log(`Gathering Final Deployment Status`, null, logger);
 
         if (response.numberComponentErrors == 0) {
-            return 'Unable to fetch report, Check your org for details';
+            if (response.details.runTestResult.codeCoverageWarnings) {
+                this.displayCodeCoverageWarnings(response.details.runTestResult.codeCoverageWarnings, logger);
+                return 'Unable to deploy due to unsatisfactory code coverage and/or test failures';
+            } else return 'Unable to fetch report, Check your org for details';
         } else if (response.numberComponentErrors > 0) {
             this.printMetadataFailedToDeploy(response.details.componentFailures, logger);
             return response.errorMessage;
@@ -62,6 +65,7 @@ export default class DeployErrorDisplayer {
     ) {
         let table = new Table({
             head: ['Name', 'Message'],
+            chars: ZERO_BORDER_TABLE,
         });
 
         if (Array.isArray(codeCoverageWarnings)) {
@@ -72,7 +76,7 @@ export default class DeployErrorDisplayer {
             table.push([codeCoverageWarnings['name'], codeCoverageWarnings.message]);
         }
 
-        if (table.length > 1) {
+        if (table.length >= 1) {
             SFPLogger.log(
                 'Unable to deploy due to unsatisfactory code coverage, Check the following classes:',
                 LoggerLevel.WARN,