Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LDAP provider for Bucket STS API #1585

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add LDAP provider for Bucket STS API #1585

merged 1 commit into from
Aug 22, 2024
+811 −94

Conversation

matheuscscp
Copy link
Collaborator

Fixes #1564

@matheuscscp matheuscscp force-pushed the bucket-sts-endpoint-ldap branch 2 times, most recently from 52de017 to 89aadd4 Compare August 18, 2024 23:14
@matheuscscp matheuscscp marked this pull request as ready for review August 18, 2024 23:15
@matheuscscp matheuscscp added area/bucket Bucket related issues and pull requests area/api API related issues and pull requests enhancement New feature or request labels Aug 18, 2024
darkowlzz
darkowlzz reviewed Aug 20, 2024
View reviewed changes
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
internal/controller/bucket_controller.go Outdated Show resolved Hide resolved
internal/controller/bucket_controller.go Show resolved Hide resolved
darkowlzz
darkowlzz approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me.
The LDAP server tests to verify the interaction looks great.

Left a few minor comments.

pkg/minio/minio_test.go Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Show resolved Hide resolved
@matheuscscp
Add LDAP provider for Bucket STS API
10ac113 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
stefanprodan
stefanprodan approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

@matheuscscp matheuscscp merged commit 74e82d2 into main Aug 22, 2024
9 checks passed
@matheuscscp matheuscscp deleted the bucket-sts-endpoint-ldap branch August 22, 2024 11:50
@stefanprodan stefanprodan added this to the Bucket GA milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests area/bucket Bucket related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
Bucket GA
Development

Successfully merging this pull request may close these issues.

Add support for LDAP STS endpoint for Bucket generic provider
3 participants
@matheuscscp @darkowlzz @stefanprodan