Skip to content

Commit

Permalink
helmrepo: Remove migration log event
Browse files Browse the repository at this point in the history
This will be logged/event emitted forever once in the lifecycle of
HelmRepository OCI object because all new objects have to remove the
.status.observedGeneration which is set to -1 by the API defaulting.
Better to perform the object conversion internally without any log or
event.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
  • Loading branch information
darkowlzz committed Dec 14, 2023
1 parent 82b1381 commit a242bda
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions internal/controller/helmrepository_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,5 @@ func (r *HelmRepositoryReconciler) migrationToStatic(ctx context.Context, sp *pa
return ctrl.Result{}, err
}

r.eventLogf(ctx, obj, eventv1.EventTypeTrace, "Migration",
"removed artifact and finalizer to migrate to static HelmRepository of type OCI")
return ctrl.Result{}, nil
}

0 comments on commit a242bda

Please sign in to comment.