Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for fetching archives over HTTP #375

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Add package for fetching archives over HTTP #375

merged 2 commits into from
Oct 10, 2022

Conversation

stefanprodan
Copy link
Member

Move the ArtifactFetcher from kustomize-controller.

Changes:

  • rename ArtifactFetcher to ArchiveFetcher
  • rename the typed error from ArtifactFoundError to FileNotFoundError
  • add tests using github.com/fluxcd/pkg/testserver

PS. The ArchiveFetcher should be used in both kustomize and helm controllers.

@stefanprodan stefanprodan requested a review from hiddeco October 10, 2022 10:47
http/fetch/archive_fetcher.go Outdated Show resolved Hide resolved
http/fetch/archive_fetcher.go Outdated Show resolved Hide resolved
http/fetch/archive_fetcher.go Outdated Show resolved Hide resolved
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants