ssa: Add read function that validates resources

ssa/utils.go

@@ -140,6 +140,7 @@ func ReadObject(r io.Reader) (*unstructured.Unstructured, error) {
 }
 
 // ReadObjects decodes the YAML or JSON documents from the given reader into unstructured Kubernetes API objects.
+// The documents which do not subscribe to the Kubernetes Object interface, are silently dropped from the result.
 func ReadObjects(r io.Reader) ([]*unstructured.Unstructured, error) {
 	reader := yamlutil.NewYAMLOrJSONDecoder(r, 2048)
 	objects := make([]*unstructured.Unstructured, 0)
@@ -175,6 +176,50 @@ func ReadObjects(r io.Reader) ([]*unstructured.Unstructured, error) {
 	return objects, nil
 }
 
+// ReadKubernetesObjects decodes the YAML or JSON documents from the given reader into unstructured Kubernetes API objects.
+// If any of the given resources do not subscribe to the Kubernetes Object interface, an error is returned.
+func ReadKubernetesObjects(r io.Reader) ([]*unstructured.Unstructured, error) {
+	reader := yamlutil.NewYAMLOrJSONDecoder(r, 2048)
+	objects := make([]*unstructured.Unstructured, 0)
+
+	for {
+		obj := &unstructured.Unstructured{}
+		err := reader.Decode(obj)
+		if err != nil {
+			if err == io.EOF {
+				err = nil
+				break
+			}
+			return objects, err
+		}
+
+		if obj.Object == nil {
+			continue
+		}
+
+		if obj.IsList() {
+			err = obj.EachListItem(func(item runtime.Object) error {
+				obj := item.(*unstructured.Unstructured)
+				if !IsKubernetesObject(obj) {
+					return fmt.Errorf("failed to decode Kubernetes object from: %v", obj)
+				}
+				objects = append(objects, obj)
+				return nil
+			})
+			if err != nil {
+				return objects, err
+			}
+			continue
+		}
+
+		if !IsKubernetesObject(obj) {
+			return objects, fmt.Errorf("failed to decode Kubernetes object from: %v", obj)
+		}
+	}
+
+	return objects, nil
+}
+
 // ObjectToYAML encodes the given Kubernetes API object to YAML.
 func ObjectToYAML(object *unstructured.Unstructured) string {
 	var builder strings.Builder

ssa/utils_test.go

@@ -91,3 +91,80 @@ func TestCmpMaskData(t *testing.T) {
 	}
 
 }
+
+func TestReadKubernetesObjects(t *testing.T) {
+	testCases := []struct {
+		name        string
+		resources   string
+		expectError bool
+	}{
+		{
+			name: "valid resources",
+			resources: `
+---
+apiVersion: pkg.crossplane.io/v1
+kind: Provider
+metadata:
+  name: crossplane-provider-aws1
+spec:
+  package: crossplane/provider-aws:v0.23.0
+  controllerConfigRef:
+    name: provider-aws
+---
+apiVersion: pkg.crossplane.io/v1
+kind: Provider
+metadata:
+  name: crossplane-provider-aws2
+spec:
+  package: crossplane/provider-aws:v0.23.0
+  controllerConfigRef:
+    name: provider-aws
+`,
+			expectError: false,
+		},
+		{
+			name: "some invalid resources",
+			resources: `
+---
+piVersion: pkg.crossplane.io/v1
+kind: Provider
+metadata:
+  name: crossplane-provider-aws1
+spec:
+  package: crossplane/provider-aws:v0.23.0
+  controllerConfigRef:
+    name: provider-aws
+---
+apiVersion: pkg.crossplane.io/v1
+kind: Provider
+metadata:
+  name: crossplane-provider-aws2
+spec:
+  package: crossplane/provider-aws:v0.23.0
+  controllerConfigRef:
+    name: provider-aws
+`,
+			expectError: true,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			_, err := ReadKubernetesObjects(strings.NewReader(tc.resources))
+			if err != nil && !tc.expectError {
+				t.Errorf("unexpected error: %v", err)
+			}
+
+			if err != nil && tc.expectError {
+				validObj, readErr := ReadObjects(strings.NewReader(tc.resources))
+				if readErr != nil {
+					t.Errorf("unexpected error: %v", readErr)
+				}
+
+				if len(validObj) != 1 {
+					t.Errorf("unexpected objects: %v", validObj)
+				}
+			}
+		})
+	}
+}