Exclude eventv1.MetaTokenKey from event metadata #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventv1.MetaTokenKey is required to be considered in rate limiting but it is only for internal use by flux components and should not be sent to the alert provider. Remove eventv1.MetaTokenKey from the metadata of event before processing the event for various matching alerts. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
changed the title
darkowlzz
force-pushed
the
exclude-token
branch
from
09c18b4 to
68c3824
Compare
stefanprodan
added
the
backport:release/v1.2.x
stefanprodan
approved these changes
Dec 13, 2023
hiddeco
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
This is in heavy need of more functional tests, but for now it looks good to me. Thanks @darkowlzz 🙇
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventv1.MetaTokenKeyis required to be considered in rate limiting but it is only for internal use by flux components and should not be sent to alert providers. Removeeventv1.MetaTokenKeyfrom the metadata of event before processing it for matching alerts.Fixes #650
NOTE: Initially, I added it in
cleanupMetadata()and found out during manual testing that it removes the metadata too early which excludes it from rate limiter. Also tried adding it inenhanceEventWithAlertMetadata()but realized that this is too late. The same metadata will be removed for every single alert the event matches with. Removing the internal metadata right at the beginning of the event handler seems to be most appropriate.