Remove URL syntax validation for provider address entirely #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
darkowlzz
reviewed
Dec 12, 2023
darkowlzz
approved these changes
Dec 12, 2023
stefanprodan
added
area/alerting
|
Successfully created backport PR for |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #680
In #564 we discussed removing the HTTP/S validation for the
.spec.addressfield of aProviderobject, and #565 was filed for implementing it. That PR missed removing the validation performed by the now deceasedProviderReconciler. This validation was carried over to the Event Handler, and in this PR I'm removing the validation for good.