Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matrix alerting provider #233

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Aug 18, 2021

Closes #229
Success Message:
Screenshot 2021-08-24 at 3 53 11 PM

Error Message:
Screenshot 2021-08-24 at 3 53 51 PM

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@dholbach
Copy link
Member

Not sure if this would make things more complicated, but the matrix provider could use shoutrrr too: https://containrrr.dev/shoutrrr/v0.5/services/overview/

@somtochiama
Copy link
Member Author

somtochiama commented Aug 25, 2021

matrix provider could use shoutrrr too

I missed that. I will update it so that it uses shoutrr instead

@somtochiama
Copy link
Member Author

@dholbach I am currently having an issue using the current version of shoutrrr with matrix so I am looking into it. But, I have opened another PR that makes it easier to add notification providers supported by Shoutrr

@stefanprodan
Copy link
Member

stefanprodan commented Aug 26, 2021

I'm for taking this as it is and refactor later if shoutrrr works ok. @somtochiama please rebase and squash the commits.

@@ -27,8 +27,8 @@ const (

// ProviderSpec defines the desired state of Provider
type ProviderSpec struct {
// Type of provider
// +kubebuilder:validation:Enum=slack;discord;msteams;rocket;generic;github;gitlab;bitbucket;azuredevops;googlechat;webex;sentry;azureeventhub;telegram;lark
// Type of provide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Type of provider please undo this down below too.

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🌹

@stefanprodan stefanprodan changed the title Matrix Notification Add Matrix alerting provider Aug 26, 2021
@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Aug 26, 2021
@stefanprodan stefanprodan merged commit eb73033 into fluxcd:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for notifying into matrix
3 participants