Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kustomize components #754

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add support for Kustomize components #754

merged 1 commit into from
Dec 5, 2022

Conversation

klausenbusk
Copy link
Contributor

@klausenbusk klausenbusk commented Oct 28, 2022 •
edited
Loading

Fix #753

This has to be merged after: fluxcd/pkg#412.

@klausenbusk
Copy link
Contributor Author

@stefanprodan can you have a look? :)

@klausenbusk klausenbusk force-pushed the components branch 2 times, most recently from e82b8d8 to 220e503 Compare November 10, 2022 13:23
@stefanprodan
Copy link
Member

Given that Kustomize components are v1alpha1 and they can be dropped at any time from upstream, we need to tell users not to rely on this feature in production. We also need to mark the field as experimental in Flux API via a comment. Please add a section here and document the components field and its restrictions. Thanks!

@klausenbusk klausenbusk force-pushed the components branch 4 times, most recently from be9931b to e83980a Compare November 15, 2022 10:21
stefanprodan
stefanprodan reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add components to the docs here https://github.com/fluxcd/kustomize-controller/blob/main/docs/spec/v1beta2/kustomization.md#override-kustomize-config

@klausenbusk klausenbusk force-pushed the components branch 3 times, most recently from f623f0e to 9cd7310 Compare November 15, 2022 11:14
@stefanprodan
Copy link
Member

@klausenbusk please run make generate manifests api-docs and force push the changes.

@stefanprodan stefanprodan added enhancement New feature or request area/kustomize Kustomize related issues and pull requests labels Nov 16, 2022
@klausenbusk
Copy link
Contributor Author

klausenbusk commented Nov 16, 2022 •
edited
Loading

@klausenbusk please run make generate manifests api-docs and force push the changes.

Done, but with the refactor in #763 this is not mergable. Looks like I must create a PR against https://github.com/fluxcd/pkg and get that in first.

@stefanprodan
Copy link
Member

Yes we need to get the components mapping in fluxcd/pkg/kustomize so that Flux users can build manifests locally and diff them with the CLI. Sorry for this, I should’ve mention this earlier.

@klausenbusk klausenbusk force-pushed the components branch 2 times, most recently from be2549f to 484358c Compare November 18, 2022 11:42
@klausenbusk
Copy link
Contributor Author

pkg PR created: fluxcd/pkg#412. The github.com/fluxcd/pkg/kustomize dependency must be updated when said PR is in.

@stefanprodan stefanprodan mentioned this pull request Nov 23, 2022
Closed
22 tasks
@klausenbusk
Copy link
Contributor Author

I guess a new pkg kustomize tag is needed, before this can get in.

@stefanprodan
Copy link
Member

@klausenbusk I've tagged kustomize/v0.11.0 please update go.mod and run make tidy.

@klausenbusk
Add support for Kustomize components
b25dea8 
Fix fluxcd#753

Signed-off-by: Kristian Klausen <kristian@klausen.dk>
@klausenbusk
Copy link
Contributor Author

Rebased and bumped github.com/fluxcd/pkg/kustomize in go.mod.

stefanprodan
stefanprodan approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @klausenbusk 🏅

@stefanprodan stefanprodan merged commit a0c79e1 into fluxcd:main Dec 5, 2022
@klausenbusk klausenbusk deleted the components branch December 7, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/kustomize Kustomize related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Kustomize components
2 participants
@klausenbusk @stefanprodan