This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make release build cope with v prefixed tags
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
build/release-publishing
branch
2 times, most recently
from
187e101 to
79c9a7c
Compare
As we want to publish our images without the `v` prefix, some modifications have been made to the `docker/image-tag` helper script to remove the `v` prefix from the calculated tag. In addition, the amount of tags it returns has been limited to one, as multiple tags will make the build fail due to `-ldflags "-X main.version=<tagA> <tagB>"` not being a valid argument.
hiddeco
force-pushed
the
build/release-publishing
branch
from
79c9a7c to
5ce58cc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we want to publish our images without the
vprefix, somemodifications have been made to the
docker/image-taghelper script toremove the
vprefix from the calculated tag.In addition, the amount of tags it returns has been limited to one, as
multiple tags will make the build fail due to
-ldflags "-X main.version=<tagA> <tagB>"not being a valid argument.