This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make OwnedByHelmRelease default to true
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work around an edge case scenarios some users have reported where the release manifest does not result in any resources (or they are all skipped), and the `HelmRelease` is therefore falsely marked as 'not being owned by'. This should all be refactored to an `ownerReference`, so that we can make use of Kubernetes' garbage collection functionalities[1] and no longer reinvent the wheel. [1]: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#owners-and-dependents
stefanprodan
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around an edge case scenarios some users have reported where
the release manifest does not result in any resources (or they are
all skipped), and the
HelmReleaseis therefore falsely marked as'not being owned by'.
This should all be refactored to an
ownerReference, so that we canmake use of Kubernetes' garbage collection functionalities1 and no
longer reinvent the wheel.