This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: configure go logger to log using our go-kit logger #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansedich
force-pushed
the
go-logger-fix
branch
from
cb7c39e to
0e3a32b
Compare
hiddeco
reviewed
Feb 17, 2020
cmd/helm-operator/main.go
Outdated
| @@ -159,6 +160,10 @@ func main() { | |||
| logger = log.With(logger, "caller", log.DefaultCaller) | |||
| } | |||
|
|
|||
| // configure go logger to output using go-kit log | |||
| logWriter := helm.NewLogWriter(logger) | |||
There was a problem hiding this comment.
Given this is now utilized as a global thing, I think it should be moved to an utils package.
stefansedich
force-pushed
the
go-logger-fix
branch
from
0e3a32b to
52f4f52
Compare
hiddeco
approved these changes
Feb 17, 2020
hiddeco
force-pushed
the
go-logger-fix
branch
from
52f4f52 to
0efce7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all logging is wrapped using our logger so that the things like the users preferred logging format is respected for all logs even those logging directly to
log.Printf.This somewhat tackles #301 but due to the reasons mentioned over there adding log context to these log lines is not possibly without introducing changes over in Helm itself.
Tested this using an unknown hook as seen to be logging using
log.Printfhere https://github.com/helm/helm/blob/840bbc951ea026297a5afeffdf913bd6bc79f20f/pkg/releaseutil/manifest_sorter.go#L192