This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: support retrying rollbacks #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
enhancement/retry-rollback
branch
3 times, most recently
from
e894be6 to
cbaf9ac
Compare
hiddeco
force-pushed
the
enhancement/retry-rollback
branch
2 times, most recently
from
6e37143 to
71403ae
Compare
This commit adds support for retrying rollbacks using `.spec.rollback.retry` until the configured `.spec.rolback.maxRetries` count is reached (defaults to 5, setting it to 0 means infinite). The reset of the counter happens after a successful upgrade or a change (e.g. chart change, `.spec` change). This makes it possible to for example recover from transient errors that were the cause of the rollback, and not a persistent chart or values failure.
hiddeco
force-pushed
the
enhancement/retry-rollback
branch
from
71403ae to
fb0bd3b
Compare
hiddeco
force-pushed
the
enhancement/retry-rollback
branch
from
fb0bd3b to
f825282
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for retrying rollbacks using
.spec.rollback.retryuntil the configured.spec.rolback.maxRetriescount is reached (defaults to 5, setting it to 0 means infinite).This makes it possible to for example recover from transient errors that were the cause of the rollback, and not a persistent chart or values failure. The reset of the counter happens after a successful
upgrade or a change (e.g. chart change,
.specchange).Fixes #241