#562. chart is upgraded to out-of-sync. sync before upgrading

cmd/helm-operator/main.go

@@ -293,7 +293,7 @@ func main() {
 	// _before_ starting it or else the cache sync seems to hang at
 	// random
 	opr := operator.New(log.With(logger, "component", "operator"),
-		*logReleaseDiffs, kubeClient, hrInformer, queue, rel)
+		*logReleaseDiffs, kubeClient, hrInformer, queue, rel, gitChartSync)
 	go ifInformerFactory.Start(shutdown)
 
 	// wait for the caches to be synced before starting _any_ workers

pkg/operator/operator.go

@@ -2,6 +2,7 @@ package operator
 
 import (
 	"fmt"
+	"github.com/fluxcd/helm-operator/pkg/api"
 	"os"
 	"path"
 	"sync"
@@ -44,6 +45,7 @@ type Controller struct {
 	hrSynced cache.InformerSynced
 
 	release *release.Release
+	apiServer api.Server
 
 	// workqueue is a rate limited work queue. This is used to queue work to be
 	// processed instead of performing it as soon as a change happens. This
@@ -64,7 +66,8 @@ func New(
 	kubeclientset kubernetes.Interface,
 	hrInformer hrv1.HelmReleaseInformer,
 	releaseWorkqueue workqueue.RateLimitingInterface,
-	release *release.Release) *Controller {
+	release *release.Release,
+	apiServer api.Server) *Controller {
 
 	// Add helm-operator types to the default Kubernetes Scheme so Events can be
 	// logged for helm-operator types.
@@ -81,6 +84,7 @@ func New(
 		releaseWorkqueue: releaseWorkqueue,
 		recorder:         recorder,
 		release:          release,
+		apiServer:        apiServer,
 	}
 
 	controller.logger.Log("info", "setting up event handlers")
@@ -275,6 +279,10 @@ func (c *Controller) enqueueUpdateJob(old, new interface{}) {
 		return
 	}
 
+	if csDiff := cmp.Diff(oldHr.Spec.ChartSource,newHr.Spec.ChartSource); csDiff != "" {
+		c.apiServer.SyncMirrors()
+	}
+
 	c.enqueueJob(new)
 }