Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use corev1 event type for sending events #908

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

souleb
Copy link
Member

@souleb souleb commented Mar 7, 2024

This is a follow up to #907 that used the wrong event types.

@souleb souleb added the area/helm Helm related issues and pull requests label Mar 7, 2024
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the add-reconciliation-events branch from abf15c1 to ff14212 Compare March 7, 2024 21:00
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@souleb souleb merged commit 5e83e51 into main Mar 7, 2024
6 checks passed
@souleb souleb deleted the add-reconciliation-events branch March 7, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants