Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PATCH rule for events in manager-role #76

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Sep 10, 2020

During high custom resource count / low interval tests, I was greated
with a cannot patch resource "events" message. This happened due to
event compaction, where it will perform a patch instead of a create.
By giving the role the permission to do so this should no longer pose
a problem.

During high custom resource count / low interval tests, I was greated
with a `cannot patch resource "events"` message. This happened due to
event compaction, where it will perform a patch instead of a create.
By giving the role the permission to do so this should no longer pose
a problem.
@hiddeco hiddeco added the bug Something isn't working label Sep 10, 2020
@hiddeco hiddeco requested a review from seaneagan September 10, 2020 19:15
@stefanprodan stefanprodan merged commit 47d6e9d into master Sep 11, 2020
@stefanprodan stefanprodan deleted the rbac-patch-events branch September 11, 2020 06:21
jtyr pushed a commit to jtyr/fluxcd-helm-controller that referenced this pull request Dec 14, 2023
Minor tweak to pass targetNamespace to klipper-helm job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants