Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oomwatch: auto-detect well known cgroup paths #641

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 10, 2023

This PR adds support for recognizing cgroup v1 paths, and allows for the configuration of alternative absolute path locations using --oom-watch-max-memory-path and --oom-watch-current-memory-path.

Fixes #640

@hiddeco hiddeco added bug Something isn't working enhancement New feature or request labels Mar 10, 2023
@hiddeco hiddeco force-pushed the improve-cgroup-discovery branch from 3ae7c43 to 6541524 Compare March 10, 2023 13:18
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🏅

This commit adds support for recognizing cgroup v1 paths, and allows for
the configuration of alternative absolute path locations using
`--oom-watch-max-memory-path` and `--oom-watch-current-memory-path`.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the improve-cgroup-discovery branch from f2f51c0 to b732420 Compare March 10, 2023 14:08
@hiddeco hiddeco merged commit 99f6339 into main Mar 10, 2023
@hiddeco hiddeco deleted the improve-cgroup-discovery branch March 10, 2023 14:27
@hiddeco hiddeco changed the title oomwatch: auto detect well known cgroup paths oomwatch: auto-detect well known cgroup paths Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOMWatch feature gate leads to not starting pod on Ubuntu 20.04 host
2 participants