Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cosign verification of Helm charts stored as OCI artifacts in container registries #545

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Oct 19, 2022

If implemented users can reconcile charts with cosign verification enabled.

This have to be merged after fluxcd/source-controller#925.

Signed-off-by: Soule BA bah.soule@gmail.com

@souleb souleb force-pushed the enable-cosign-verif branch from a62a4a9 to 73393d9 Compare October 19, 2022 14:34
@stefanprodan stefanprodan changed the title Add cosign verification to the chart Template Enable Cosign verification of Helm charts stored as OCI artifacts in container registries Oct 19, 2022
@souleb souleb added enhancement New feature or request area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Oct 19, 2022
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me to be merged after the official source-controller release is out, and my comment has been addressed. Thanks @souleb 🙇

go.mod Outdated Show resolved Hide resolved
@souleb souleb force-pushed the enable-cosign-verif branch from 73393d9 to cb597cb Compare October 21, 2022 13:34
If implemented users can reconcile charts with cosign verification
enabled.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the enable-cosign-verif branch from cb597cb to 2b0e355 Compare October 21, 2022 14:18
@stefanprodan
Copy link
Member

After we release source-controller we need to add in this PR an e2e test for podinfo keyless.

@souleb souleb force-pushed the enable-cosign-verif branch from 5ba941a to 3a0c17e Compare October 21, 2022 14:51
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the enable-cosign-verif branch from 3a0c17e to e5f7b8c Compare October 21, 2022 14:59
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

@stefanprodan stefanprodan merged commit 543b3a9 into fluxcd:main Oct 21, 2022
@souleb souleb deleted the enable-cosign-verif branch October 21, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants