Set QPS and Burst when impersonating service account #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After apply this patch, helmrelease reconcilation finished in 55.092283623s |
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
fix-qps-burst
branch
from
c861f32 to
1410615
Compare
hiddeco
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Made an attempt to move the growing set of constructor flags to options, but need to have a bit of a think about what they should be wired to (e.g. rest.Config or the MemoryRESTClientGetter). This looks good to me for now, thanks @stefanprodan and @uderik 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't map the client QPS and Burst setting resulting in client-side throttling when impersonating, making the kube-prom-stack upgrade take 25 minutes instead of one minute.