Skip to content

Commit

Permalink
reconcile: do not emit HelmChartInSync event
Browse files Browse the repository at this point in the history
Due to the frequency, this would otherwise suppress other Kubernetes
Events which are more important. Especially when the `.spec.interval`
of the HelmRelease is set to a low value.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
  • Loading branch information
hiddeco committed Dec 7, 2023
1 parent 842a942 commit 47fbb37
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion internal/reconcile/helmchart_template.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ func (r *HelmChartTemplate) Reconcile(ctx context.Context, req *Request) error {
newChart.Spec.SourceRef.Kind, newChart.GetNamespace(), newChart.Spec.SourceRef.Name)

ctrl.LoggerFrom(ctx).Info(msg)
r.eventRecorder.Eventf(req.Object, eventv1.EventTypeTrace, "HelmChartInSync", msg)
default:
err = fmt.Errorf("unexpected action '%s' for %s", entry.Action.String(), entry.Subject)
return err
Expand Down

0 comments on commit 47fbb37

Please sign in to comment.