Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Bump libgit2 to 1.5.0 #40

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Bump libgit2 to 1.5.0 #40

merged 1 commit into from
Oct 5, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Oct 5, 2022

DEPRECATE_HARD has been disabled to allow for the func git_indexer_hash
to be used, as git2go hasn't moved on from it yet.

This change redirect the git2go dependency to Flux's git2go fork.
Note that upstream has a v35 Git tag that points to the v34 Go module,
which currently does not work. Instead Flux's fork has a v34 Git tag.

More information: libgit2/git2go#938

@pjbgf pjbgf requested a review from aryan9600 October 5, 2022 13:20
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

DEPRECATE_HARD has been disabled to allow for the func git_indexer_hash
to be used, as git2go hasn't moved on from it yet.

This change redirect the git2go dependency to Flux's git2go fork.
Note that upstream has a v35 Git tag that points to the v34 Go module,
which currently does not work. Instead Flux's fork has a v34 Git tag.

More information:
libgit2/git2go#938

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf added this to the GA milestone Oct 5, 2022
@pjbgf pjbgf merged commit 2f0e341 into fluxcd:main Oct 5, 2022
@pjbgf pjbgf deleted the bump-libgit2-1.5.0 branch October 5, 2022 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants