Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Remove musl #37

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Remove musl #37

merged 2 commits into from
Jul 31, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jul 29, 2022

Must be tested with:

  • IAC image creation
  • IAC Linux development
  • IAC Darwin development
  • SC image creation
  • SC Linux development
  • SC Darwin development

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

Paulo Gomes added 2 commits July 31, 2022 11:23
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf merged commit 8072fa4 into fluxcd:main Jul 31, 2022
@pjbgf pjbgf deleted the remove-musl branch July 31, 2022 10:32
export CXX=$(MUSL-PREFIX)-g++
export AR=$(MUSL-PREFIX)-ar
endif
export ALLOW_THREADLESS_LIBGIT2=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This env var isn't read anywhere in the project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to work together with the proposed change in git2go upstream. I will remove this in a follow-up PR.

@pjbgf pjbgf added this to the GA milestone Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants