Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add support for libgit2-only builds #24

Merged
merged 4 commits into from
May 19, 2022
Merged

Conversation

aryan9600
Copy link
Member

This PR adds support for building libgit2 without linking with openssl and libssh2. This can be done by running
hack/static.sh build_libgit2_only or LIBGIT2_ONLY=true make build.

Further modifies, the CI workflows to release four artifacts:

  • linux-x86_64-libgit2-only-lib.tar.gz (new)
  • linux-x86_64-libgit2-all-libs.tar.gz (replacing linux-x86_64-libs.tar.gz)
  • darwin-libs-libgit2-only.tar.gz (new)
  • darwin-libgit2-all-libs.tar.gz (replacing darwin-libs.tar.gz)

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 requested review from pjbgf and hiddeco and removed request for pjbgf May 14, 2022 20:08
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 added enhancement New feature or request area/tooling (Developer) tooling related pull requests or issues labels May 14, 2022
@pjbgf pjbgf added this to the GA milestone May 16, 2022
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryan9600 great work here. We may need to review one point around Darwin, apart from that LGTM.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @aryan9600!

LGTM

@hiddeco hiddeco merged commit 1282600 into fluxcd:main May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling (Developer) tooling related pull requests or issues enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants