[bootstrap] Make sure we reconcile with the right reconciliation method #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
added
bug
|
Ok so let's ask the people who reported the issue to test this before we merge it. Our e2e tests work fine without this change, so we have no means of validating this PR on our own. |
1 task
Signed-off-by: Soule BA <soule@weave.works>
souleb
force-pushed
the
reconcile-repository
branch
from
e153382 to
ec2aa13
Compare
|
@hiddeco the bug described in fluxcd/go-git-providers#67 might be fixed with the change I introduced in the way we patch repository for github. Can you confirm this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3065
Signed-off-by: Soule BA soule@weave.works