Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple values for flux create hr --values-from #2829

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Accept multiple values for flux create hr --values-from #2829

merged 1 commit into from
Jun 23, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jun 9, 2022

This pull request updates --values-from flag for flux create helmrelease to accept a comma-separated list of object references.
e.g

flux create hr podinfo  --values-from=Secret/my-secret-values,ConfigMap/my-values

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@somtochiama somtochiama marked this pull request as ready for review June 10, 2022 06:47
@somtochiama somtochiama requested a review from stefanprodan June 10, 2022 06:47
@stefanprodan stefanprodan changed the title Accept multiple values from create_helmrelease --values-from flag Accept multiple values for flux create hr --values-from Jun 10, 2022
@stefanprodan stefanprodan added enhancement New feature or request area/UX area/helm Helm related issues and pull requests labels Jun 10, 2022
@stefanprodan
Copy link
Member

@somtochiama pflag does know about multi value flags, it knows how to parse the , and also accepts multiple flags. We want --values-from to behave like --value, to do this valuesFrom must be an array set with StringSliceVar. In your implementation, setting multiple -values-from has no effect, the last one overrides all others.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama please squash and rebase

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 874b05c into fluxcd:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants