Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC-0000] Introduce the Flux RFC template #2085

Merged
merged 4 commits into from
Nov 30, 2021
Merged

[RFC-0000] Introduce the Flux RFC template #2085

merged 4 commits into from
Nov 30, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Nov 15, 2021 •
edited
Loading

In many cases, new features and enhancements are proposed on flux2/discussions.
A proposal is discussed in public by maintainers, contributors, users and other interested parties.
After some form of consensus is reached between participants, the proposed changes go through the
pull request process where the implementation details are reviewed, approved or rejected by maintainers.

Some proposals may be substantial, and for these we ask for a design process to be followed
so that all stakeholders can be confident about the direction Flux is evolving in.

The "RFC" (request for comments) process is intended to provide a consistent and
controlled path for substantial changes to enter Flux.

The RFC template is heavily inspired by Rust RFCs and Kubernetes KEPs.

@stefanprodan stefanprodan requested review from a team, squaremo and hiddeco and removed request for a team November 15, 2021 11:29
hiddeco
hiddeco reviewed Nov 15, 2021
View reviewed changes
rfcs/README.md Outdated Show resolved Hide resolved
@stefanprodan stefanprodan added the area/rfc Feature request proposals in the RFC format label Nov 15, 2021
darkowlzz
darkowlzz reviewed Nov 15, 2021
View reviewed changes
rfcs/README.md Outdated Show resolved Hide resolved
darkowlzz
darkowlzz approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together.
LGTM!

squaremo
squaremo reviewed Nov 16, 2021
View reviewed changes
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
@hiddeco hiddeco changed the title Introduce the Flux RFC template [RFC-0000] Introduce the Flux RFC template Nov 18, 2021
hiddeco
hiddeco reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is filled against fluxcd/flux2 (and not e.g. fluxcd/community), making the scope of this template limited to fluxcd/flux2 and fluxcd/*-controller (I assume). Can we documented this scope?

Other than that (and the tiny nitpick comment), I think this is a good step forward. 🙇

rfcs/README.md Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member Author

@hiddeco once this is merged, next step is to update https://github.com/fluxcd/community/blob/main/GOVERNANCE.md#proposal-process and link to this readme, as now we only link to fluxcd/flux2/discussions

@stefanprodan stefanprodan force-pushed the rfc-template branch 2 times, most recently from 1458684 to 30555b7 Compare November 18, 2021 13:20
yebyen
yebyen suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@yebyen yebyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure! I found a few RCFs which I assume should read RFC. 👍 LGTM with fixes

rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
makkes
makkes reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing the process being streamlined a bit more! Maybe the template should be in a file of its own so people can just copy that and start writing their proposal.

@stefanprodan
Copy link
Member Author

Maybe the template should be in a file of its own so people can just copy that and start writing their proposal.

Yes, once this gets approved I'll create a dir rfc-0000 with the template makrdown in the README.md. People will copy the dir, fill the RFC number and the template.

@stefanprodan stefanprodan force-pushed the rfc-template branch 2 times, most recently from daf2d1e to 6d94ffa Compare November 24, 2021 14:06
squaremo
squaremo reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC process is mentioned twice, but not described here. Is it yet to be explained (in which case I suggest putting it after the examples of substantial changes), or elsewhere (in which case, a link would be good)?

rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Show resolved Hide resolved
@stefanprodan
Introduce the Flux RFC template
8354ac9 
The RFC template is heavily inspired by Rust RFCs and Kubernetes KEPs.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add status, creation and last update date fields to RFC template
c5b2c67 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the rfc-template branch 2 times, most recently from 507c787 to 6dcd9bc Compare November 30, 2021 13:14
squaremo
squaremo approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy that the process and template are sensible 👍
Thanks for setting our RFC system in motion Stefan 🍇

rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
@stefanprodan
Add RFC process
99a0c47 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan force-pushed the rfc-template branch 3 times, most recently from d40a116 to f4ebf31 Compare November 30, 2021 15:12
@stefanprodan
Add template to RFC-0000
2c3cb1a 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
hiddeco approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for putting work into this @stefanprodan, and an additional 🎩-tip for following up on all comments (and nitpicks) to reach consensus. 🍍

@stefanprodan stefanprodan merged commit 3ab5787 into main Nov 30, 2021
@stefanprodan stefanprodan deleted the rfc-template branch November 30, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebyen yebyen yebyen requested changes

@hiddeco hiddeco hiddeco approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

@makkes makkes makkes approved these changes

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
area/rfc Feature request proposals in the RFC format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefanprodan @squaremo @makkes @darkowlzz @yebyen @hiddeco