This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Skip AWS Metadata API pre-flight check when regions are passed via config #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
force-pushed
the
brave-intl-skip-aws-api-check
branch
from
eebe032 to
b9f511a
Compare
Signed-off-by: eV <ev@7pr.xyz> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
force-pushed
the
brave-intl-skip-aws-api-check
branch
from
b9f511a to
58c073b
Compare
|
I was running into the same issue as #3124, but using ec2 instead of Fargate. This change solved my problem too. |
|
After reviewing the issue with @gonzalobarbitta I see this as a bugfix with little to no potential for breakage, and I will plan to include it in the next patch release. Thanks very much for collaborating on this 👍 💯 |
kingdonb
changed the title
hiddeco
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
LGTM, thanks for the combined effort @kingdonb @gonzalobarbitta 💯
This was referenced Jul 30, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3124
Reportedly fixes #3015
Thanks to @evq and sorry for the delay.
I'll see if we can get this in 1.23.0.This is planned to be included now in 1.23.2.Since this issue sat for a while and had lots of discussion, I had to research it again. The best summary of who is affected is here:
#3124 (comment)
The short version is, if you are following best-practices with EKS+IRSA, and still using Flux v1 with its image update automation feature on ECR, then it probably affects you. I don't have any reason to think there's any potential this fix could represent a breaking change.