Better support for FnPtr ...
#854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ranjitjhala -- Awesome, thanks. This pr fixes two of the issues related to FnPtr, and makes the rest into #829 errors. don't think we need any more FnPtr support from what I can see. |
nilehmann
approved these changes
Oct 18, 2024
crates/flux-refineck/src/checker.rs
Outdated
| } | ||
| mir::CallKind::FnPtr { operand, .. } => { | ||
| let ty = self.check_operand(infcx, env, terminator_span, operand)?; | ||
| if let Some(BaseTy::FnPtr(fn_sig)) = ty.as_bty_skipping_existentials() { |
There was a problem hiding this comment.
Let's try not to skip existentials if we can avoid it
Suggested change
| if let Some(BaseTy::FnPtr(fn_sig)) = ty.as_bty_skipping_existentials() { | |
| if let TyKind::Indexed(BaseTy::FnPtr(fn_sig), _) = ty.kind() { |
If ty is not directly a TyKind::Indexed we should unpack it first.
There was a problem hiding this comment.
I'm assuming that if its already an Indexed then unpack will not do anything?
There was a problem hiding this comment.
Yes, if it's already Indexed no need to do unpack (it would be a noop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #807