add flux-lptest #6301
Merged
add flux-lptest #6301
+83
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
reviewed
Sep 24, 2024
src/cmd/builtin/lptest.c
Outdated
| } | ||
|
|
||
| // vi:ts=4 sw=4 expandtab | ||
|
|
There was a problem hiding this comment.
Python linter maybe didn't like this trailing line? 🤷
There was a problem hiding this comment.
What it's checking C files now??? Ok.
There was a problem hiding this comment.
Oh, I guess this set of pre-commit hooks are not Python specific:
hooks:
- id: check-added-large-files
- id: check-case-conflict
- id: check-docstring-first
- id: check-shebang-scripts-are-executable
- id: end-of-file-fixer
- id: trailing-whitespace
- id: mixed-line-ending
Problem: the "lptest" test program in t/shell/lptest.c is useful for diagnosing problems with standard I/O buffering outside of the testsuite. Since it is so trivial, just make it a built-in flux command.
Problem: the test suite lptest executable now duplicates flux lptest. Remove the test suite version and point tests at the flux version.
|
OK well that did it. I'll set MWP - thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6301 +/- ##
==========================================
+ Coverage 83.32% 83.34% +0.02%
==========================================
Files 522 523 +1
Lines 86093 86124 +31
==========================================
+ Hits 71733 71780 +47
+ Misses 14360 14344 -16
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem the
lptestutility is useful for testing standard I/O buffering on a deployed system, but it only exists in the source tree.At least, I keep finding a use for it and accessing it is not always convenient.
This elevates the
lptesttest program to a flux command.I didn't feel a man page was warranted for this one.