flux-bulksubmit: support {} in more options like --cwd=, --signal=, --taskmap=, etc.
#6299
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The Xcmd class that implements option argument mutability in flux-bulksubmit(1) has a manual list of mutable options that is missing some useful options. Update the list to include some missing options, like --cwd=, --signal=, --taskmap=, and --begin-time=. Fixes flux-framework#6295
garlick
approved these changes
Sep 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6299 +/- ##
==========================================
+ Coverage 83.32% 83.33% +0.01%
==========================================
Files 522 522
Lines 86093 86093
==========================================
+ Hits 71733 71747 +14
+ Misses 14360 14346 -14
|
|
The specific options that support |
|
Right, for another day maybe. This looks good to go to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The Xcmd class that implements option argument mutability in flux-bulksubmit(1) has a manual list of mutable options that is missing some useful options.
Update the list to include some missing options, like --cwd=, --signal=, --taskmap=, and --begin-time=.
Fixes #6295