Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve symbol conflicts in wakelock_plus by updating Pigeon prefix #82

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

weitsai
Copy link
Contributor

@weitsai weitsai commented Dec 20, 2024

Updated the Pigeon configuration for wakelock_plus to use a unique ObjCOptions.prefix ("WKP") to prevent symbol conflicts with other plugins such as image_picker_ios.

Changes include:

  • Modified the Pigeon prefix from "FLT" to "WAKELOCKPLUS" in messages.dart.
  • Regenerated the Pigeon files to reflect the new prefix.
  • Cleaned and rebuilt the project to ensure compatibility.

wakelock_plus/pigeons/messages.dart Outdated Show resolved Hide resolved
Updated the Pigeon configuration for wakelock_plus to use a unique ObjCOptions.prefix ("WKP") to prevent symbol conflicts with other plugins such as image_picker_ios.

Changes include:
- Modified the Pigeon prefix from "FLT" to "WAKELOCK" in `messages.dart`.
- Regenerated the Pigeon files to reflect the new prefix.
- Cleaned and rebuilt the project to ensure compatibility.
Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegotori
Copy link
Collaborator

@weitsai Thanks for your contribution. Once the automation goes green, then I'll release a new build.

@weitsai
Copy link
Contributor Author

weitsai commented Dec 21, 2024

@weitsai Thanks for your contribution. Once the automation goes green, then I'll release a new build.

Thanks for the update! I'll wait for the automation to complete. Let me know if there's anything else I can assist with.

@diegotori
Copy link
Collaborator

@weitsai I'm taking over your PR to the finish line, mainly to regenerate the Pigeons.

@weitsai
Copy link
Contributor Author

weitsai commented Dec 21, 2024

Ok, thanks!

@diegotori diegotori merged commit e6fb6a4 into fluttercommunity:main Dec 21, 2024
14 checks passed
diegotori added a commit that referenced this pull request Dec 21, 2024
@diegotori
Copy link
Collaborator

@weitsai deployed as wakelock_plus and wakelock_plus_platform_interface, versions 1.2.10 and 1.2.2 respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants