Skip to content

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Oct 8, 2020

No description provided.

@slightfoot slightfoot self-requested a review October 22, 2020 18:52
@jpnurmi jpnurmi added the connectivity_plus Connectivity Plus label Oct 22, 2020
@miquelbeltran
Copy link
Member

Run this on my machine and worked, although I saw the following exception:

[ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Bad state: StreamSink is closed
#0      _StreamSinkImpl.add (dart:io/io_sink.dart:154:7)
#1      _Socket.add (dart:io-patch/socket_patch.dart:1848:38)
#2      DBusClient._sendMessage (package:dbus/src/dbus_client.dart:707:13)
<asynchronous suspension>
#3      DBusClient._sendMethodCall (package:dbus/src/dbus_client.dart:655:5)
<asynchronous suspension>

As well, the e2e test did not pass when running on Linux.

Run the following test (inside the example project)

flutter drive --target=./test_driver/test/connectivity_e2e.dart

And got:

flutter: (The following exception is now available via WidgetTester.takeException:)
flutter: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
flutter: The following StateError was thrown running a test:
flutter: Bad state: StreamSink is closed
flutter: 
flutter: When the exception was thrown, this was the stack:
flutter: #0      _StreamSinkImpl.add (dart:io/io_sink.dart:154:7)
flutter: #1      _Socket.add (dart:io-patch/socket_patch.dart:1848:38)
flutter: #2      DBusClient._sendMessage (package:dbus/src/dbus_client.dart:707:13)
flutter: <asynchronous suspension>
flutter: <asynchronous suspension>
flutter: (elided one frame from package:stack_trace)
flutter: 
flutter: The test description was:
flutter:   test connectivity result

@jpnurmi
Copy link
Member Author

jpnurmi commented Oct 23, 2020

Hopefully fixed in dbus.dart soon 😄

@jpnurmi
Copy link
Member Author

jpnurmi commented Oct 23, 2020

There were lots of last minute cleanup & fixup changes done collectively all over the plugins right before the release. I'll rebase this PR and try to catch up with all those changes later tonight or during the weekend.

@jpnurmi jpnurmi force-pushed the feature/connectivity_plus_linux branch 2 times, most recently from c732e52 to 0678450 Compare October 23, 2020 16:43
@jpnurmi
Copy link
Member Author

jpnurmi commented Oct 23, 2020

I tried pinning the dbus dependency to version 0.0.0-dev.19 to avoid canonical/dbus.dart#111 (throws an exception starting from 0.0.0-dev.20):

[connectivity_plus_linux]: Package validation found the following potential issue:
[connectivity_plus_linux]: * Your dependency on "dbus" should allow more than one version. For example:
[connectivity_plus_linux]:   
[connectivity_plus_linux]:   dependencies:
[connectivity_plus_linux]: 
[connectivity_plus_linux]:     dbus: ^0.0.0-dev.19
[connectivity_plus_linux]:   
[connectivity_plus_linux]:   Constraints that are too tight will make it difficult for people to use your package
[connectivity_plus_linux]:   along with other packages that also depend on "dbus".

Then I tried with dbus: ">=0.0.0-dev.18 <=0.0.0-dev.19":

[connectivity_plus_linux]: Package validation found the following potential issue:
[connectivity_plus_linux]: * Packages dependent on a pre-release of another package should themselves be published as a pre-release version. If this package needs dbus version 0.0.0-dev.18, consider publishing the package as a pre-release instead.
[connectivity_plus_linux]:   See https://dart.dev/tools/pub/publishing#publishing-prereleases For more information on pre-releases.

@jpnurmi
Copy link
Member Author

jpnurmi commented Oct 23, 2020

For the failing test, looks like we should do something like here: flutter/plugins@1685a2

@miquelbeltran
Copy link
Member

hi! whats stopping us from merging this one?

@jpnurmi jpnurmi force-pushed the feature/connectivity_plus_linux branch from 44c54b7 to d82bbec Compare December 9, 2020 20:37
@jpnurmi jpnurmi merged commit a6d4759 into main Dec 9, 2020
@jpnurmi jpnurmi deleted the feature/connectivity_plus_linux branch December 9, 2020 20:52
@Jules369-ZM Jules369-ZM mentioned this pull request Jun 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
connectivity_plus Connectivity Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants