-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Linux support to Connectivity Plus #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run this on my machine and worked, although I saw the following exception:
As well, the e2e test did not pass when running on Linux. Run the following test (inside the example project)
And got:
|
There were lots of last minute cleanup & fixup changes done collectively all over the plugins right before the release. I'll rebase this PR and try to catch up with all those changes later tonight or during the weekend. |
c732e52
to
0678450
Compare
I tried pinning the dbus dependency to version 0.0.0-dev.19 to avoid canonical/dbus.dart#111 (throws an exception starting from 0.0.0-dev.20):
Then I tried with
|
For the failing test, looks like we should do something like here: flutter/plugins@1685a2 |
6b4cc5e
to
64862d7
Compare
64862d7
to
44c54b7
Compare
hi! whats stopping us from merging this one? |
44c54b7
to
d82bbec
Compare
No description provided.