Ability to display custom notification title on Android #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ochyra
changed the title
…ithub.com/m-ochyra/flutter_downloader into feature/notification-alternative-filename
|
I added also fix for crash on older Android versions: |
|
When will this branch be merged in? |
# Conflicts: # android/src/main/java/vn/hunghd/flutterdownloader/DownloadWorker.java
|
Is any chance to merge in the nearest time? I also need this feature. |
# Conflicts: # android/src/main/java/vn/hunghd/flutterdownloader/DownloadWorker.java
|
@m-ochyra Hi, would you be interested in solving the merge conflicts so that we can merge this? |
# Conflicts: # README.md # android/gradle/wrapper/gradle-wrapper.properties # android/src/main/java/vn/hunghd/flutterdownloader/DownloadTask.java # android/src/main/java/vn/hunghd/flutterdownloader/DownloadWorker.java # android/src/main/java/vn/hunghd/flutterdownloader/FlutterDownloaderPlugin.java # android/src/main/java/vn/hunghd/flutterdownloader/TaskDao.java # android/src/main/java/vn/hunghd/flutterdownloader/TaskDbHelper.java # android/src/main/res/xml/provider_paths.xml # lib/src/downloader.dart
# Conflicts: # android/.idea/compiler.xml # android/.idea/gradle.xml # android/.idea/misc.xml
Sure. Done :) |
|
@m-ochyra Thanks! 😎 |
bartekpacia
added a commit
that referenced
this pull request
Aug 18, 2022
This reverts commit 5e80a37.
bartekpacia
added a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to display title of currently downloaded e-book in notification instead of displaying its file name (which is hash) or URL. This PR adds ability to set
notificationTitleparam toFlutterDownloader.enqueue().