Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): migrated to flutter_lints with additional rules #99

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

daadu
Copy link
Member

@daadu daadu commented Dec 17, 2021

No description provided.

@daadu daadu changed the title chore(linter): migrated to flutter_lints with additional rules and obeying it chore(linter): migrated to flutter_lints with additional rules Dec 17, 2021
@daadu daadu marked this pull request as ready for review December 17, 2021 12:21
@daadu daadu requested a review from WieFel December 17, 2021 12:22
@daadu
Copy link
Member Author

daadu commented Dec 17, 2021

@WieFel Could replace the current "analyze" action with one that fails it the linter rules are not followed. Current one count the "pub score". What do you think?

This package needs a breather - haven't touched it for a while. Will start with fixing all lint issues - check #100.

@daadu
Copy link
Member Author

daadu commented Dec 17, 2021

The CI steps that are in my mind as of now:

  1. analyze - fails if linter rules are not followed
  2. widget test - run flutter widget test
  3. build example and demo app - check if no issue in building it
  4. integration test - run integration test against example and demo app

What do you think about it? You got time this days?

@WieFel
Copy link
Collaborator

WieFel commented Dec 17, 2021

@daadu you're completely right!
I am currently totally busy :(
But I will be able to review PRs, if needed, or maybe do some very small tasks if we manage to split up the work ;)

@daadu daadu merged commit 14a751b into master Dec 17, 2021
@daadu daadu deleted the migrate-to-lints branch December 17, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants