Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Smooth Scrolling for Parent Widget When enableGestureTouch is Disabled #15

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

LOCKEDFILE
Copy link
Contributor

Issue

  • even when enableGestureTouch is disabled, the GestureDetector is still taking touch events, preventing scrolling within scrollable parent widgets.

Therefore, I've modified the following code to address the aforementioned issue

GestureDetector(
    onVerticalDragUpdate :  _tiltConfig.enableGestureTouch ?  (_) {} : null ,  
    onHorizontalDragUpdate :  _tiltConfig.enableGestureTouch ?  (_) {} : null ,  
    ...

@LOCKEDFILE LOCKEDFILE requested a review from AmosHuKe as a code owner August 14, 2024 04:25
@AmosHuKe AmosHuKe added the c: bug Something isn't working label Aug 14, 2024
Copy link
Member

@AmosHuKe AmosHuKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LOCKEDFILE LGTM! Thanks for your time.

enableGestureTouch: false enableGestureTouch: true
enableGestureTouch_false.mp4
enableGestureTouch_true.mp4

@AmosHuKe AmosHuKe merged commit 37932ed into fluttercandies:dev Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants