Revert "Revert "Remove DevTools survey metadata json and add redirect."" #9942
Conversation
kenzieschmoll
requested review from
atsansone,
parlough,
sfshaza2,
khanhnwin,
domesticmouse and
MaryaBelanger
as code owners
|
The new CORS configuration on the new direct URL was confirmed to work within devtools? |
|
Visit the preview URL for this PR (updated for commit 3bde8ff): https://flutter-docs-prod--pr9942-revert-9941-revert-9935-dt-s-bv28paoo.web.app |
|
Let's hold off on landing this. I have confirmed that the cloud storage request succeeds locally, but I'm not sure if the redirect works as expected. |
|
@kenzieschmoll Could you test the redirect on the staged site https://flutter-docs-prod--pr9942-revert-9941-revert-9935-dt-s-bv28paoo.web.app/f/dart-devtools-survey-metadata.json to see if that works within DevTools? If that works, should work fine one the live site as well. Thanks! |
|
Even without this PR landed, https://docs.flutter.dev/f/dart-devtools-survey-metadata.json is redirecting to https://storage.googleapis.com/flutter-uxr/surveys/devtools-survey-metadata.json. @parlough any idea why that might be? |
|
Looks like cd09215 accidentally relanded your commit and added it back. I'm not at a computer to undo it right now, so if it's causing issues, mind updating this PR or opening a new one? Otherwise I can get to it later. Thank you :) |
|
Sounds good. There's no issue having this here and in the cloud storage bucket, so I'm happy to push this off to later. Going to close for now to make things easier to track. Have a nice holiday!! @kenzieschmoll ☃️ |
this redirect was accidentally committed. related: 919cb74 The goal is to land #9942, but we need to confirm the redirects are working even on master. I was noticing some strange behavior there with trying to access the cloud storage urls but I have not had time to dig into it. This redirect is causing some failures on master so we need to land this asap. Once this is green and approved, feel free to land as I'm going to be away from my computer starting tomorrow.
Reverts #9941 (which is a reland of #9935). The CORS issue has been fixed (see flutter/uxr#128 and flutter/uxr#130).