Revert "Update layout tutorial for current best practices" #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d93a46c.
parlough
requested review from
domesticmouse,
johnpryan,
khanhnwin,
MaryaBelanger,
atsansone and
sfshaza2
as code owners
|
Visit the preview URL for this PR (updated for commit a4792b7): https://flutter-docs-prod--pr9927-revert-9893-fix-2108-hypjcol8.web.app |
|
\cc @domesticmouse For approval since this is currently resulting in a few user experience issues and it'll be easier to land this revert (and fix in a new PR) than trying to fix them all now. Thank you! |
domesticmouse
approved these changes
Dec 14, 2023
This was referenced Dec 14, 2023
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Dec 15, 2023
…lutter#9927)" This reverts commit 4579089.
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Dec 19, 2023
…lutter#9927)" This reverts commit 4579089.
atsansone
added a commit
that referenced
this pull request
Dec 20, 2023
…tes (#9937) Reverts #9927 Fixes #2108 Fixes #1799 Fixes #9118 Based on discussion with @parlough . - #9925 caused by adding `width: 100%` to `site-figure-container`. Likely should be `max-width`. Need to change one line in this. ```css .site-figure-container { flex: 0 1 auto; width: 100%; max-width: 100%; ``` - The code block in the `Update the app to display the button section` section failed to render. - Step 4 of the [Interactivity page](https://docs.flutter.dev/ui/interactivity#step-4-plug-the-stateful-widget-into-the-widget-tree) was changed so the diff no longer makes sense. --------- Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9893
Some code blocks were unintentionally changed, image styles on other pages were broken, and at least one of the diff code blocks isn't rendering.
Fixes #9925
\cc @atsansone