Remove layout basics codelab #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
requested review from
atsansone,
sfshaza2,
khanhnwin,
domesticmouse and
MaryaBelanger
as code owners
|
Visit the preview URL for this PR (updated for commit 2f8145f): https://flutter-docs-prod--pr9876-misc-remove-layout-basics-co-3brc0ptu.web.app |
domesticmouse
approved these changes
Nov 30, 2023
|
So... I LOVE the idea of removing this, but it is a highly viewed page! That's why I didn't remove it already. |
sfshaza2
approved these changes
Nov 30, 2023
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Dec 11, 2023
We currently have three locations introducing or exploring layout basics in Flutter: [Layouts in Flutter](https://docs.flutter.dev/ui/layout), [Building layouts tutorial](https://docs.flutter.dev/ui/layout/tutorial), and this [Basic Flutter layout concepts codelab](https://docs.flutter.dev/codelabs/layout-basics). We need a better and consolidated layout story. I think rather than hobbling along with these three pieces of outdated and overlapping material, we need to start from a cleaner place where users don't have so many unnecessary choices. As a first step, I think we need to just remove one of these, and I think this codelab is a good choice to start with for a few reasons: - The DartPad technology (testing, solutions, etc) it relies on is going away soon - @johnpryan This page is the main user of DartPad testing functionality on the Flutter site. - The many embedded DartPads result in a slow site loading experience and an essential non-functional mobile experience - The code on the page does not have excerpts and has been outdated, broken, or filled with warnings for surprising amounts of time multiple times in the past - The formatting of the page and text is inconsistent with the rest of the site - With little teaching around each layout type, the API docs are likely a better resource and often have runnable snippets This type of learning experience should eventually be replaced by a consolidated interactive step-by-step in-browser learning experience for intro Flutter concepts. Contributes to flutter#9738 Closes flutter#6300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have three locations introducing or exploring layout basics in Flutter: Layouts in Flutter, Building layouts tutorial, and this Basic Flutter layout concepts codelab.
We need a better and consolidated layout story. I think rather than hobbling along with these three pieces of outdated and overlapping material, we need to start from a cleaner place where users don't have so many unnecessary choices. As a first step, I think we need to just remove one of these, and I think this codelab is a good choice to start with for a few reasons:
This type of learning experience should eventually be replaced by a consolidated interactive step-by-step in-browser learning experience for intro Flutter concepts.
Contributes to #9738
Closes #6300