Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced flutter pub run with dart run #9302

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Replaced flutter pub run with dart run #9302

merged 1 commit into from
Aug 25, 2023

Conversation

atsansone
Copy link
Contributor

Fixes #9301

@atsansone atsansone added fix.copy Needs copy editing review.tech Awaiting Technical Review labels Aug 25, 2023
parlough
parlough approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was hesitant to make this change earlier because the error messages with a messed up setup are pretty confusing still, but I'm exploring ways to improve those in pub.

@parlough parlough merged commit 45f9578 into flutter:main Aug 25, 2023
9 checks passed
@parlough parlough removed the review.tech Awaiting Technical Review label Aug 25, 2023
@atsansone
Copy link
Contributor Author

Understood, but the message that flutter pub run displays makes it clear that it's deprecated. We can be consistent with the command at least.

@parlough
Copy link
Member

parlough commented Aug 25, 2023 •
edited
Loading

Oh sorry, I meant when running dart run instead. If there is a Flutter dependency, it currently gives sort of obscure failure messages if your Dart SDK does not match the Flutter SDK.

I'm still happy with the change, just wanted to note why we didn't make it earlier :)

@sfshaza2 sfshaza2 removed the fix.copy Needs copy editing label Sep 5, 2023
atsansone added a commit to atsansone/website that referenced this pull request Sep 19, 2023
@atsansone
Replaced flutter pub run with dart run (flutter#9302)
1a335da 
Fixes flutter#9301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

Assignees

@parlough parlough

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change all instances of flutter pub run with dart run
3 participants
@atsansone @parlough @sfshaza2