Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictive back migration guide confirmation dialog example #9244

Merged
merged 6 commits into from
Aug 21, 2023
Merged

Predictive back migration guide confirmation dialog example #9244

merged 6 commits into from
Aug 21, 2023

Conversation

justinmc
Copy link
Contributor

@justinmc justinmc commented Aug 14, 2023 •
edited
Loading

A user requested this example be added to the migration guide on Discord. I think it's a reasonable request.

Follow up on: #8952
Framework PR: flutter/flutter#132249

@justinmc justinmc self-assigned this Aug 14, 2023
sfshaza2
sfshaza2 reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a couple minor comments, but mostly, can you give me a landing in version #?

src/release/breaking-changes/android-predictive-back.md Outdated Show resolved Hide resolved
src/release/breaking-changes/android-predictive-back.md Outdated Show resolved Hide resolved
@justinmc justinmc marked this pull request as draft August 15, 2023 19:27
@justinmc justinmc mentioned this pull request Aug 16, 2023
Merged
@parlough parlough added the review.await-update Awaiting Updates after Edits label Aug 20, 2023
@justinmc justinmc marked this pull request as ready for review August 21, 2023 16:22
@justinmc justinmc requested a review from sfshaza2 August 21, 2023 16:25
@justinmc
Copy link
Contributor Author

I also decided to add a quick section about supporting predictive back, inspired by flutter/flutter#109513 (comment).

@parlough parlough added review.tech Awaiting Technical Review and removed review.await-update Awaiting Updates after Edits labels Aug 21, 2023
@parlough parlough self-assigned this Aug 21, 2023
@parlough parlough removed the review.tech Awaiting Technical Review label Aug 21, 2023
@parlough parlough removed their assignment Aug 21, 2023
parlough
parlough approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this extra example! Looks good to me :)

@parlough parlough merged commit c42ad96 into flutter:main Aug 21, 2023
8 of 9 checks passed
@jellynoone jellynoone mentioned this pull request Nov 19, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@atsansone atsansone Awaiting requested review from atsansone

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinmc @parlough @sfshaza2